refactor(protocol-contracts): add virtual to staking functions and change private to internal#1694
Merged
melanciani merged 1 commit intomainfrom Jan 5, 2026
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 1f8f325. 🟢 All jobs passed!But CI Insights is watching 👀 |
melanciani
force-pushed
the
melanciani/refactor/protocol-contracts/staking/add_virtual_and_internal
branch
from
72714d9 to
649ce64
Compare
jatZama
previously approved these changes
Dec 30, 2025
Member
jatZama
left a comment
jatZama
left a comment
There was a problem hiding this comment.
Great work, looks a lot more practical now.
…ange private to internal
melanciani
force-pushed
the
melanciani/refactor/protocol-contracts/staking/add_virtual_and_internal
branch
from
649ce64 to
1f8f325
Compare
melanciani
changed the title
melanciani
changed the title
jatZama
approved these changes
Jan 5, 2026
melanciani
deleted the
melanciani/refactor/protocol-contracts/staking/add_virtual_and_internal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
virtualmodifier to all functions in ProtocolStaking, OperatorRewarder, and OperatorStaking contractsprivatestorage getter tointernalin both upgradeable staking contracts_getProtocolStakingStoragefunctionrefs https://github.com/zama-ai/fhevm-internal/issues/826